Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the recently added API cache helpers to satisfy RuboCop and reduces noise from RuboCop metrics checks related to those helpers.
Changes:
- Refactors
load_api_cache!to use safe navigation (&.) and updates rescued exception variable naming. - Refactors
save_api_cache!to replace long ternaries with multi-lineifexpressions for readability/compliance. - Updates
.rubocop.ymlto excludetest/test_helper.rbfrom several Metrics cops.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/test_helper.rb |
Minor refactors to make the cache load/save helpers more RuboCop-friendly and readable. |
.rubocop.yml |
Adds Metrics exclusions for test/test_helper.rb to silence RuboCop complexity/length warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rubocop was unhappy with the `save_api_cache!` and `load_api_cache!` methods introduced in #5042 - some were legit problems but it had spurious errors around method length and Cyclomatic Complexity, which are not worth fixing.
ahpook
force-pushed
the
ahpook/rubocop-wtf
branch
from
319d229 to
f25024f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The lint.yml workflow uses pull_request_target trigger, which causes actions/checkout to check out the base branch (main) by default. This means rubocop runs against main's code, not the PR's changes. Add ref parameter to checkout the PR's head branch, with fallback to github.ref for workflow_dispatch and merge_group triggers. Co-authored-by: ahpook <56753+ahpook@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/explore/sessions/f08905db-e076-48a4-8c19-6b4acc2c537c
Fix lint workflow to checkout PR branch instead of base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rubocop was unhappy with the
save_api_cache!andload_api_cache!methods introduced in #5042 - some were legit problems but it had spurious errors around method length and Cyclomatic Complexity, which are not worth fixing.Please confirm this pull request meets the following requirements:
Which change are you proposing?